Re: [PATCH v2 2/2] sequencer: fix quoting in write_author_script
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 1, 2018, 15:22 UTC
- Message-ID
- <xmqqin4u863h.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <22f98273-f7f4-adf3-1a8b-b0e4ec6029b3@talktalk.net>
Phillip Wood <phillip.wood@talktalk.net> writes:
Show 13 quoted lines
>> Is the: >> >> ...for some reason sq_dequote() called by read_author_ident() >> seems to handle the broken quoting correctly. >> >> bit outdated? We know now from patch 2/4 of my series[1] that >> read_author_ident() wasn't handling it correctly at all. It was merely >> ignoring the return value from sq_dequote() and using whatever broken >> value came back from it. > > Yes you're right, when I tested it... > > Thanks for your comments, I'll do a reroll
Thanks, both. Sounds like we are quickly converging to the resolution ;-)