Re: [PATCH] strbuf.h: format according to coding guidelines

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 28, 2018, 19:54 UTC
Message-ID: <xmqqr2hdbdp8.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180928173033.159192-1-sbeller@google.com>

Stefan Beller <sbeller@google.com> writes:

> So let's format strbuf.h in a way that we'd like to see:
> * omit the extern keyword from function declarations

OK

> * name all parameters (usually the parameters are obvious from its type,
>   but consider exceptions like
>   `int strbuf_getwholeline_fd(struct strbuf *, int, int);`

I am mildly against giving names to obvious ones.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.