From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 28 Sep 2018 19:54:11 GMT
Subject: Re: [PATCH] strbuf.h: format according to coding guidelines
Message-ID: <xmqqr2hdbdp8.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180928173033.159192-1-sbeller@google.com>

Stefan Beller <sbeller@google.com> writes:

> So let's format strbuf.h in a way that we'd like to see:
> * omit the extern keyword from function declarations

OK

> * name all parameters (usually the parameters are obvious from its type,
>   but consider exceptions like
>   `int strbuf_getwholeline_fd(struct strbuf *, int, int);`

I am mildly against giving names to obvious ones.