Re: [PATCH 1/8] sha1-array: provide oid_array_filter

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Sep 22, 2018, 12:58 UTC
Message-ID: <87h8ihk7sl.fsf@evledraar.gmail.com>
In-Reply-To: <20180921223558.65055-2-sbeller@google.com>

On Fri, Sep 21 2018, Stefan Beller wrote:

Show 10 quoted lines

> +/*
> + * Apply want to each entry in array, retaining only the entries for
> + * which the function returns true.  Preserve the order of the entries
> + * that are retained.
> + */
> +void oid_array_filter(struct oid_array *array,
> +		      for_each_oid_fn want,
> +		      void *cbdata);
> +
>  #endif /* SHA1_ARRAY_H */

The code LGTM, but this comment should instead be an update to the API docs, see my recent 5cc044e025 ("get_short_oid: sort ambiguous objects by type, then SHA-1", 2018-05-10) for an addition of a new function to this API where I added some new docs.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.