git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fetch: fix compilation warning

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 29, 2018, 18:34 UTC
Message-ID
<xmqqr2hc884s.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<4d868114-a7a5-a39b-d6d4-5a436419f105@ramsayjones.plus.com>
Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
> You probably already know, but I had to add this on top of the 'pu'
> branch to get a clean compile tonight (your 'jc/war-on-string-list'
> branch).

It was not just about squelching a warning but simply broken code that deserved to be warned/errored. I think what we have in 'pu' now is already fixed.

Thanks.
Show 7 quoted lines
>  	}
>  	hashmap_free(&remote_refs, 1);
> -	string_list_clear(&remote_refs, 0);
> +	string_list_clear(&remote_refs_list, 0);
>  }
>  
>  static struct ref *get_ref_map(struct remote *remote,
Previous: Ramsay Jones
Message 2 of 2 in “fetch: fix compilation warning”
  1. fetch: fix compilation warningRamsay Jones, Sep 27, 2018
  2. Junio C HamanoSep 29, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.