git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] fetch: fix compilation warning

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Sep 27, 2018, 22:08 UTC
Message-ID
<4d868114-a7a5-a39b-d6d4-5a436419f105@ramsayjones.plus.com>

commit 440fc7c0729 ("fetch: replace string-list used as a look-up table with a hashmap", 2018-09-25) renamed a string-list variable (while adding a hashmap of the same name) and forgot to rename the string-list variable in a call to string_list_clear().

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Junio,

You probably already know, but I had to add this on top of the 'pu' branch to get a clean compile tonight (your 'jc/war-on-string-list' branch).

Thanks!

ATB, Ramsay Jones

 builtin/fetch.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/fetch.c b/builtin/fetch.c
index 0a71953bc5..aea2e10364 100644
--- a/builtin/fetch.c
+++ b/builtin/fetch.c
@@ -391,7 +391,7 @@ static void find_non_local_tags(const struct ref *refs,
 		}
 	}
 	hashmap_free(&remote_refs, 1);
-	string_list_clear(&remote_refs, 0);
+	string_list_clear(&remote_refs_list, 0);
 }
 
 static struct ref *get_ref_map(struct remote *remote,
-- 
2.19.0
Next: Junio C Hamano
Message 1 of 2 in “fetch: fix compilation warning”
  1. fetch: fix compilation warningRamsay Jones, Sep 27, 2018
  2. Junio C HamanoSep 29, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.