From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 29 Sep 2018 18:34:59 GMT
Subject: Re: [PATCH] fetch: fix compilation warning
Message-ID: <xmqqr2hc884s.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <4d868114-a7a5-a39b-d6d4-5a436419f105@ramsayjones.plus.com>

Ramsay Jones <ramsay@ramsayjones.plus.com> writes:

> You probably already know, but I had to add this on top of the 'pu'
> branch to get a clean compile tonight (your 'jc/war-on-string-list'
> branch).

It was not just about squelching a warning but simply broken code
that deserved to be warned/errored.  I think what we have in 'pu'
now is already fixed.

Thanks.

>  	}
>  	hashmap_free(&remote_refs, 1);
> -	string_list_clear(&remote_refs, 0);
> +	string_list_clear(&remote_refs_list, 0);
>  }
>  
>  static struct ref *get_ref_map(struct remote *remote,