Re: [PATCH v2 5/5] pretty: add support for separator option in %(trailers)

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 5, 2018, 05:18 UTC
Message-ID: <xmqqr2g0hzlf.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20181104152232.20671-6-anders@0x63.nu>

Anders Waldenborg <anders@0x63.nu> writes:

Show 5 quoted lines

> +				if (opts->separator && first_printed)
> +					strbuf_addbuf(out, opts->separator);
>  				if (opts->no_key)
> -					strbuf_addf(out, "%s\n", val.buf);
> +					strbuf_addf(out, "%s", val.buf);

Avoid addf with "%s" alone as a formatter; instead say

	strbuf_addstr(out, val.buf);

cf. contrib/coccinelle/strbuf.cocci

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.