Re: [PATCH 1/1] mingw: handle absolute paths in expand_user_path()

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 12, 2018, 03:03 UTC
Message-ID: <xmqqr2fr3skw.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CACsJy8BzbEnXMRw6kB1rg+WMfu2wwJZWkAtVate98CZRSY_dLA@mail.gmail.com>

Duy Nguyen <pclouds@gmail.com> writes:

> FWIW I don't have any preference, as long as the variable can still
> have a name (that is not a symbol).

Same here.

Show 5 quoted lines

> A side question regardless of syntax. What do we do with
> %(unrecognized name)/foo? I see three options
>
>  - expand to empty, so "/foo"
>  - keep it and try the literal path "%(unrecognized name)/foo"

Neither of these is good for future proofing purposes.

>  - somehow tell the caller that the path is invalid and treat it like
> non-existing path, even if there is some real thing at "%(unrecognized
> name)/foo"

Another thing to worry about is how to spell the real thing that has such a funny name, perhaps by escaping like "%%(unrecognized name)/foo".

And from that point of view, "~runtime-prefix~/foo" (i.e. what J6t started) may make the most sense, as I do not think we need to support a username that ends with a tilde by introducing a quoting convention.