Re: [PATCH 1/1] mingw: handle absolute paths in expand_user_path()

From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Nov 7, 2018, 17:42 UTC
Message-ID: <d7a70226-3441-76c4-df6a-e8fb32249f27@ramsayjones.plus.com>
In-Reply-To: <nycvar.QRO.7.76.6.1811071217280.39@tvgsbejvaqbjf.bet>

On 07/11/2018 11:19, Johannes Schindelin wrote: [snip]

Show 19 quoted lines

>>> Hmm, this doesn't quite fit with the intended use of this
>>> function! ;-) (even on windows!)
>>>
>>> I haven't looked very deeply, but doesn't this affect all
>>> absolute paths in the config read by git_config_pathname(),
>>> along with all 'included config' files?
>>
>> I think so.  I have not thought things through to say if replacing a
>> "full path in the current drive" with system_path() is a sensible
>> thing to do in the first place, but I am getting the impression from
>> review comments that it probably is not.
>>
>>> I am pretty sure that I would not want the absolute paths
>>> in my config file(s) magically 'moved' depending on whether
>>> git has been compiled with 'runtime prefix' support or not!
> 
> The cute thing is: your absolute paths would not be moved because we are
> talking about Windows. Therefore your absolute paths would not start with
> a forward slash.

Ah, sorry, I must have misunderstood a comment in your cover letter:

    The reason is this: something like this (make paths specified e.g. via 
    http.sslCAInfo relative to the runtime prefix) is potentially useful
    also in the non-Windows context, as long as Git was built with the
    runtime prefix feature.

... so I thought you meant to add this code for POSIX systems as well.

My mistake. :(

ATB, Ramsay Jones