git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Makefile: use compat regex with SANITIZE=address

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 17, 2020, 17:37 UTC
Message-ID
<xmqqr1zydlwt.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20200116175138.GA691238@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 22 quoted lines
> Recent versions of the gcc and clang Address Sanitizer produce test
> failures related to regexec(). This triggers with gcc-10 and clang-8
> (but not gcc-9 nor clang-7). Running:
>
>   make CC=gcc-10 SANITIZE=address test
>
> results in failures in t4018, t3206, and t4062.
> ...
> We can work around that by having the preprocessor replace regexec with
> git_regexec (both in the callers and in the actual implementation), and
> we truly end up with a call to our custom regex code, even when
> compiling with ASan. That's probably a good thing to do anyway, as it
> means anybody looking at the symbols later (e.g., in a debugger) would
> have a better indication of which function is which. So we'll do the
> same for the other common regex functions (even though just regexec() is
> enough to fix this ASan problem).
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
>  Makefile             | 3 +++
>  compat/regex/regex.h | 5 +++++
>  2 files changed, 8 insertions(+)

I guess we should treat this the same way as the recent vcproj "fix" by Dscho, i.e. fast-track to 'maint' to ensure that all public integration branches has it soonish?

Thanks.
Previous: Jonathan NiederNext: Jeff King
Message 4 of 7 in “Makefile: use compat regex with SANITIZE=address”
  1. Makefile: use compat regex with SANITIZE=addressJeff King, Jan 16, 2020
  2. t4018: drop "debugging" cat from hunk-header testsJeff King, Jan 16, 2020
  3. Jonathan NiederJan 16, 2020
  4. Junio C HamanoJan 17, 2020
  5. Jeff KingJan 17, 2020
  6. brian m. carlsonJan 17, 2020
  7. Jeff KingJan 18, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.