Re: [PATCH] Makefile: use compat regex with SANITIZE=address

From: Jeff King <peff@peff.net>
Date: Jan 17, 2020, 17:49 UTC
Message-ID: <20200117174931.GA8958@coredump.intra.peff.net>
In-Reply-To: <xmqqr1zydlwt.fsf@gitster-ct.c.googlers.com>

On Fri, Jan 17, 2020 at 09:37:22AM -0800, Junio C Hamano wrote:

Show 13 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > Recent versions of the gcc and clang Address Sanitizer produce test
> > failures related to regexec(). This triggers with gcc-10 and clang-8
> > (but not gcc-9 nor clang-7). Running:
> >
> >   make CC=gcc-10 SANITIZE=address test
> >
> > results in failures in t4018, t3206, and t4062.
> [...]
> I guess we should treat this the same way as the recent vcproj "fix"
> by Dscho, i.e. fast-track to 'maint' to ensure that all public
> integration branches has it soonish?

I don't think there's a huge rush. It only triggers ASan and recent compilers, so AFAIK nobody has been hitting this in CI. I occasionally test with whatever is the most recent compiler in Debian unstable to see if it turns up any interesting new warnings or errors (but gcc-9 is still the default there).

-Peff