git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Makefile: use compat regex with SANITIZE=address

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Jan 17, 2020, 23:39 UTC
Message-ID
<20200117233931.GB6570@camp.crustytoothpaste.net>
In-Reply-To
<20200117174931.GA8958@coredump.intra.peff.net>
On 2020-01-17 at 17:49:31, Jeff King wrote:
Show 21 quoted lines
> On Fri, Jan 17, 2020 at 09:37:22AM -0800, Junio C Hamano wrote:
> 
> > Jeff King <peff@peff.net> writes:
> > 
> > > Recent versions of the gcc and clang Address Sanitizer produce test
> > > failures related to regexec(). This triggers with gcc-10 and clang-8
> > > (but not gcc-9 nor clang-7). Running:
> > >
> > >   make CC=gcc-10 SANITIZE=address test
> > >
> > > results in failures in t4018, t3206, and t4062.
> > [...]
> > I guess we should treat this the same way as the recent vcproj "fix"
> > by Dscho, i.e. fast-track to 'maint' to ensure that all public
> > integration branches has it soonish?
> 
> I don't think there's a huge rush. It only triggers ASan and recent
> compilers, so AFAIK nobody has been hitting this in CI. I occasionally
> test with whatever is the most recent compiler in Debian unstable to see
> if it turns up any interesting new warnings or errors (but gcc-9 is
> still the default there).

I've reported this as a bug to Debian on the clang-8 and libasan6 packages, along with a trivial test case. Hopefully this will get fixed soon.

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
Previous: Jeff KingNext: Jeff King
Message 6 of 7 in “Makefile: use compat regex with SANITIZE=address”
  1. Makefile: use compat regex with SANITIZE=addressJeff King, Jan 16, 2020
  2. t4018: drop "debugging" cat from hunk-header testsJeff King, Jan 16, 2020
  3. Jonathan NiederJan 16, 2020
  4. Junio C HamanoJan 17, 2020
  5. Jeff KingJan 17, 2020
  6. brian m. carlsonJan 17, 2020
  7. Jeff KingJan 18, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.