Re: [PATCH 13/15] push: only get triangular when needed
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 31, 2021, 06:48 UTC
- Message-ID
- <xmqqr1hnv1no.fsf@gitster.g>
- In-Reply-To
- <20210529074458.1916817-14-felipe.contreras@gmail.com>
Felipe Contreras <felipe.contreras@gmail.com> writes:
Show 27 quoted lines
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
> builtin/push.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/builtin/push.c b/builtin/push.c
> index c220f70795..818ca4c5c9 100644
> --- a/builtin/push.c
> +++ b/builtin/push.c
> @@ -205,8 +205,8 @@ static const char *get_upstream_ref(struct branch *branch, const char *remote_na
> static void setup_default_push_refspecs(struct remote *remote)
> {
> struct branch *branch;
> - int triangular = remote != remote_get(NULL);
> const char *dst;
> + int triangular;
>
> switch (push_default) {
> case PUSH_DEFAULT_MATCHING:
> @@ -225,6 +225,7 @@ static void setup_default_push_refspecs(struct remote *remote)
> die(_(message_detached_head_die), remote->name);
>
> dst = branch->refname;
> + triangular = remote != remote_get(NULL);
>
> switch (push_default) {
> default:This is another change that got helped by an earlier split. Good.