Re: [PATCH v2 6/6] doc: push: explain default=simple correctly

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: May 31, 2021, 17:31 UTC
Message-ID: <60b51d6c93c7d_279c820856@natae.notmuch>
In-Reply-To: <5fa7e3f4-60a0-c3b1-83f2-054ed38e5683@gmail.com>

Mathias Kunter wrote:

Show 23 quoted lines

> Am 31.05.21 um 17:14 schrieb Felipe Contreras:
> >> In your above example, I'm in centralized workflow, but I can still push
> >> the fix-1 branch to origin without having to configure an upstream
> >> branch for it.
> > 
> > No, you can't:
> > 
> >    % git push
> >    fatal: The current branch fix-1 has no upstream branch.
> >    To push the current branch and set the remote as upstream, use
> > 
> >        git push --set-upstream origin fix-1
> > 
> > Isn't that problem the one you originally described [1]?
> 
> It is.
> 
> > Maybe you are thinking this patch series implements the fix I proposed:
> > it doesn't.
> 
> Yes, I thought so. Sorry for the confusion. When I asked "will your 
> provided patch fix these failing push commands" you answered "It's not 
> really a patch (yet), but yeah: it will". So that's why I thought so.

I have not yet sent the patch to change the current behavior.

First I sent a bunch of patches to reorganize the code so it's more clear what it's actually doing.

Once those patches are merged, then I will probably send the one to change the behavior.

I will include you in the Cc list when I do so.

Show 9 quoted lines

> My point simply is: For the sake of easiness of use, I think the 
> following should work with the default settings of git:
> 
>     git clone $url
>     git checkout -b fix-1
>     # do commits
>     git push           # should push to origin/fix-1
>     # others push to origin/fix-1 (but no local changes)
>     git pull           # should pull from origin/fix-1

I agree.

> Will this be implemented?

It's hard do say, but it probably won't.

All my suggestions for improvement are mostly disregarded, and considering *nobody* has said a word about whether or not the current behavior makes sense, I don't think there are very good chances of changing it.

Consider my last mail "git push default doesn't make sense" [1]: nobody replied.

But maybe that's my fault, because even though I broke the In-Reply-To in order to start a new thread, it seems mail handling software still uses References (incorrectly IMO).

So maybe if I start a new thread completely fresh people will notice, and reply.

I will do so with a patch once I'm done with the reorganization.

In my experience you need to convince either Junio Hamano, or Jeff King for any change in behavior to happen, and until they do comment on this one it's fair to say it won't happen.

Cheers.

[1] https://lore.kernel.org/git/60b15cd2c4136_2183bc20893@natae.notmuch/

-- 
Felipe Contreras