Re: [PATCH 0/4] test-tool: split up "read-cache" tool

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 7, 2021, 22:50 UTC
Message-ID: <xmqqr1hdthla.fsf@gitster.g>
In-Reply-To: <cover-0.4-0000000000-20210607T115454Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

Show 15 quoted lines

> When the sparse index topic was being discussed I suggested that the
> t/helper/read-cache.c tool was getting to the point of doing too many
> things and should be split up.
>
> Since that series has landed on master here's that suggestion again in
> the form of patches on top of master. The 4/4 patch is a "while I was
> at it" addition of an extra perf test for index refreshing.
>
> 1. https://lore.kernel.org/git/20210317132814.30175-6-avarab@gmail.com/
>
> Ævar Arnfjörð Bjarmason (4):
>   test-tool: split up test-tool read-cache
>   test-tools: migrate read-cache-perf to parse_options()
>   test-tools: migrate read-cache-again to parse_options()
>   read-cache perf: add a perf test for refresh_index()

Is the contrast between tool and tools deliberate?

Show 11 quoted lines

>  Makefile                         |  2 ++
>  t/helper/test-read-cache-again.c | 47 +++++++++++++++++++++++++++
>  t/helper/test-read-cache-perf.c  | 47 +++++++++++++++++++++++++++
>  t/helper/test-read-cache.c       | 56 +++++++++++++-------------------
>  t/helper/test-tool.c             |  2 ++
>  t/helper/test-tool.h             |  2 ++
>  t/perf/p0002-read-cache.sh       |  7 +++-
>  t/t7519-status-fsmonitor.sh      |  2 +-
>  8 files changed, 130 insertions(+), 35 deletions(-)
>  create mode 100644 t/helper/test-read-cache-again.c
>  create mode 100644 t/helper/test-read-cache-perf.c