Re: [PATCH 0/4] test-tool: split up "read-cache" tool

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 8, 2021, 23:26 UTC
Message-ID: <xmqq8s3kndk4.fsf@gitster.g>
In-Reply-To: <87tum838u8.fsf@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Show 16 quoted lines

>>> Ævar Arnfjörð Bjarmason (4):
>>>   test-tool: split up test-tool read-cache
>>>   test-tools: migrate read-cache-perf to parse_options()
>>>   test-tools: migrate read-cache-again to parse_options()
>>>   read-cache perf: add a perf test for refresh_index()
>>
>> Is the contrast between tool and tools deliberate?
>
> Yes, I figured "test-tool:" describes the main entry point of the
> "test-tool somecmd", so if I split up "somecmd" into "othercmd" that's a
> "test-tool" change.
>
> But "test-tools:" when I'm modifying particular tools, I can change 2/4
> and 3/4 it to "test-tool read-cache-perf:" and "test-tool
> read-cache-again" (or another thing you suggest) if you think this
> warrants a re-roll.

I actually meant s/test-tools:/test-tool:/ and nothing else, as changes to read-cache-perf and changes to read-cache-again both fall into the same test-tool umbrella. It's not like we benefit from having two separate <area> (as in "<area>: <description>") designators for read-cache-perf and read-cache-again---in a larger picture, they are both things around test-tool helper.

Thanks.