Re: [PATCH v2 0/4] test-tool: split up "read-cache" tool
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 25, 2021, 00:18 UTC
- Message-ID
- <xmqq35qyl6ks.fsf@gitster.g>
- In-Reply-To
- <YSVwioizjGKVSXQA@nand.local>
Taylor Blau <me@ttaylorr.com> writes:
Show 6 quoted lines
> If we're looking for things to clean up, I do like the conversion to the > parse-options API instead of reading argv ourselves, but probably > otherwise prefer the code as-is instead of split across many files. > > But I may be in the minority, and there may be others who do find the > split-up version easier to grok.
FWIW, you're not alone. I too like the use of parse_options, but I fail to be enthused by changes to churn the test helper binary.