Re: [PATCH] git-p4: fix failed submit by skip non-text data files

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 21, 2021, 03:43 UTC
Message-ID: <xmqqr1gvj30m.fsf@gitster.g>
In-Reply-To: <20210620075607.1228-1-dorgonman@hotmail.com>

"dorgon.chang" <dorgon.chang@gmail.com> writes:

Show 6 quoted lines

> The skip  will not affect actual submit files in the resulting cl,
> the diff line description will only appear in submit template, 
> so you can review what changed before actully submit to p4.
> ...
> I don't know if add any message here will be helpful for users, 
> so I choose to just skip binary content, since it already append filename previously.

These are both good things to write in the proposed log message.

Thanks.