Re: [PATCH] git-p4: fix failed submit by skip non-text data files

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 18, 2021, 13:24 UTC
Message-ID: <nycvar.QRO.7.76.6.2106181523090.57@tvgsbejvaqbjf.bet>
In-Reply-To: <YMsveynHB8MNiz+S@bagger.lan>

Hi Simon,

On Thu, 17 Jun 2021, Simon Hausmann wrote:

Show 14 quoted lines

> On Fri, Mar 12, 2021 at 07:47:49AM +0000, dorgon chang via GitGitGadget wrote:
> > From: "dorgon.chang" <dorgonman@hotmail.com>
> >
> > If the submit contain binary files, it will throw exception and stop submit when try to append diff line description.
> >
> > This commit will skip non-text data files when exception UnicodeDecodeError thrown.
> >
> > Signed-off-by: dorgon.chang <dorgonman@hotmail.com>
>
> As suggested on
> https://github.com/git/git/pull/977#issuecomment-862197824, I'm happy to
> state that the patch looks good to me. IIRC the diff there is solely for
> the submit template, so it should only include text. That your patch
> ensures in what seems an idiomatic way.

Thank you for reviewing and chiming in.

> Signed-off-by: Simon Hausmann <simon@lst.de>

The typical way to record your review is to say `Reviewed-by:`. The `Signed-off-by:` footer is usually used to indicate that you wrote the patch, or that you shepherd it onto the Git mailing list.

Sorry to be so nit-picky...

Thanks, Dscho