git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-p4: fix failed submit by skip non-text data files

From
Simon Hausmann <simon@lst.de>
Date
Jun 17, 2021, 11:18 UTC
Message-ID
<YMsveynHB8MNiz+S@bagger.lan>
In-Reply-To
<pull.977.git.git.1615535270135.gitgitgadget@gmail.com>
On Fri, Mar 12, 2021 at 07:47:49AM +0000, dorgon chang via GitGitGadget wrote:
Show 7 quoted lines
> From: "dorgon.chang" <dorgonman@hotmail.com>
> 
> If the submit contain binary files, it will throw exception and stop submit when try to append diff line description.
> 
> This commit will skip non-text data files when exception UnicodeDecodeError thrown.
> 
> Signed-off-by: dorgon.chang <dorgonman@hotmail.com>

As suggested on https://github.com/git/git/pull/977#issuecomment-862197824, I'm happy to state that the patch looks good to me. IIRC the diff there is solely for the submit template, so it should only include text. That your patch ensures in what seems an idiomatic way.

Signed-off-by: Simon Hausmann <simon@lst.de>
Simon
Previous: dorgon chang via GitGitGadgetNext: Johannes Schindelin
Message 2 of 9 in “git-p4: fix failed submit by skip non-text data files”
  1. git-p4: fix failed submit by skip non-text data filesdorgon chang via GitGitGadget, Mar 12, 2021
  2. Simon HausmannJun 17, 2021
  3. Johannes SchindelinJun 18, 2021
  4. Junio C HamanoJun 29, 2021
  5. Simon HausmannJun 18, 2021
  6. Junio C HamanoJun 19, 2021
  7. dorgon.changJun 20, 2021
  8. Junio C HamanoJun 21, 2021
  9. git-p4: fix failed submit by skip non-text data filesdorgon chang via GitGitGadget, Jun 21, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.