Re: [PATCH v3] cache.h: auto-detect if zlib has uncompress2()

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 21, 2022, 23:23 UTC
Message-ID: <xmqqr190ekrh.fsf@gitster.g>
In-Reply-To: <patch-v3-1.1-e9cb8763fd4-20220120T011414Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> As noted in the updated commit message this approach of having an
> object just for this fallback function comes at the cost of some
> complexity, but now the compat object lives neatly in its own object.

I do not see any change in this patch adding costly complexity, but I notice lack of one possible trick that might become problem with some compilers and linkers when their zlib has uncompress2() function. Let's have this graduate very early in the next cycle, to see if anybody on a rarer system sees a complaint due to having to deal with a totally empty object file.

Will queue.