git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] cache.h: auto-detect if zlib has uncompress2()

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 22, 2022, 00:55 UTC
Message-ID
<xmqqh79wd1xf.fsf@gitster.g>
In-Reply-To
<000a01d80f20$dadd0e80$90972b80$@nexbridge.com>
<rsbecker@nexbridge.com> writes:
Show 18 quoted lines
> On January 21, 2022 6:23 PM, Junio C Hamano wrote:
>> Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
>> 
>> > As noted in the updated commit message this approach of having an
>> > object just for this fallback function comes at the cost of some
>> > complexity, but now the compat object lives neatly in its own object.
>> 
>> I do not see any change in this patch adding costly complexity, but I notice lack of
>> one possible trick that might become problem with some compilers and linkers
>> when their zlib has uncompress2() function.  Let's have this graduate very early in
>> the next cycle, to see if anybody on a rarer system sees a complaint due to having
>> to deal with a totally empty object file.
>> 
>> Will queue.
>
> On behalf of the "rarer systems", I will certainly be putting this through the regression suite.
> With thanks,
> --Randall
;-)  

I know you are on a rarer system, but I also know you need a real replacement code in the compat object file, so your linker will not be dealing with an empty object file.

Thanks.
Previous: rsbecker@nexbridge.comNext: Beat Bolli
Message 11 of 22 in “cache.h: auto-detect if zlib has uncompress2()”
  1. cache.h: auto-detect if zlib has uncompress2()Ævar Arnfjörð Bjarmason, Jan 17, 2022
  2. Junio C HamanoJan 17, 2022
  3. rsbecker@nexbridge.comJan 17, 2022
  4. René ScharfeJan 17, 2022
  5. Carlo ArenasJan 20, 2022
  6. cache.h: auto-detect if zlib has uncompress2()Ævar Arnfjörð Bjarmason, Jan 19, 2022
  7. Junio C HamanoJan 19, 2022
  8. cache.h: auto-detect if zlib has uncompress2()Ævar Arnfjörð Bjarmason, Jan 20, 2022
  9. Junio C HamanoJan 21, 2022
  10. rsbecker@nexbridge.comJan 21, 2022
  11. Junio C HamanoJan 22, 2022
  12. Beat BolliJan 23, 2022
  13. Junio C HamanoJan 23, 2022
  14. compat: auto-detect if zlib has uncompress2()Junio C Hamano, Jan 24, 2022
  15. Ævar Arnfjörð BjarmasonJan 24, 2022
  16. compat: auto-detect if zlib has uncompress2()Junio C Hamano, Jan 24, 2022
  17. Ævar Arnfjörð BjarmasonJan 24, 2022
  18. Junio C HamanoJan 24, 2022
  19. Carlo ArenasJan 25, 2022
  20. Junio C HamanoJan 25, 2022
  21. Ævar Arnfjörð BjarmasonJan 25, 2022
  22. Junio C HamanoJan 26, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.