RE: [PATCH v3] cache.h: auto-detect if zlib has uncompress2()
- From
rsbecker@nexbridge.com <rsbecker@nexbridge.com>
- Date
- Jan 21, 2022, 23:44 UTC
- Message-ID
- <000a01d80f20$dadd0e80$90972b80$@nexbridge.com>
- In-Reply-To
- <xmqqr190ekrh.fsf@gitster.g>
On January 21, 2022 6:23 PM, Junio C Hamano wrote:
Show 13 quoted lines
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes: > > > As noted in the updated commit message this approach of having an > > object just for this fallback function comes at the cost of some > > complexity, but now the compat object lives neatly in its own object. > > I do not see any change in this patch adding costly complexity, but I notice lack of > one possible trick that might become problem with some compilers and linkers > when their zlib has uncompress2() function. Let's have this graduate very early in > the next cycle, to see if anybody on a rarer system sees a complaint due to having > to deal with a totally empty object file. > > Will queue.
On behalf of the "rarer systems", I will certainly be putting this through the regression suite. With thanks, --Randall