Re: [PATCH] fetch set_head: fix non-mirror remotes in bare repositories

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 23, 2025, 21:00 UTC
Message-ID: <xmqqr04tqm86.fsf@gitster.g>
In-Reply-To: <20250112165125.130400-1-bence@ferdinandy.com>

Bence Ferdinandy <bence@ferdinandy.com> writes:

Show 10 quoted lines

> In b1b713f722 (fetch set_head: handle mirrored bare repositories,
> 2024-11-22) it was implicitly assumed that all remotes will be mirrors
> in a bare repository, thus fetching a non-mirrored remote could lead to
> HEAD pointing to a non-existent reference. Make sure we only overwrite
> HEAD if we are in a bare repository and fetching from a mirror.
> Otherwise, proceed as normally, and create
> refs/remotes/<nonmirrorremote>/HEAD instead.
>
> Signed-off-by: Bence Ferdinandy <bence@ferdinandy.com>
> Reported-by: Christian Hesse <list@eworm.de>

These should be chronological; somebody reports an issue, the patch gets written, and finally it is sent out with a Sign-off to certify that the patch is not a stolen property.

Show 5 quoted lines

> ---
>  builtin/fetch.c   | 15 ++++++++-------
>  t/t5505-remote.sh | 10 ++++++++++
>  t/t5510-fetch.sh  | 13 +++++++++++++
>  3 files changed, 31 insertions(+), 7 deletions(-)

We haven't heard from Chritian; has this been tested OK?

What the patch does does look sensible.  Thanks.