Re: [PATCH v2 2/2] fetch set_head: fix non-mirror remotes in bare repositories
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 27, 2025, 20:18 UTC
- Message-ID
- <xmqqjzagqabz.fsf@gitster.g>
- In-Reply-To
- <Z5c2CKpYM3KevMyD@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 13 quoted lines
> On Sun, Jan 26, 2025 at 11:02:11PM +0100, Bence Ferdinandy wrote: >> In b1b713f722 (fetch set_head: handle mirrored bare repositories, >> 2024-11-22) it was implicitly assumed that all remotes will be mirrors >> in a bare repository, thus fetching a non-mirrored remote could lead to >> HEAD pointing to a non-existent reference. Make sure we only overwrite >> HEAD if we are in a bare repository and fetching from a mirror. >> Otherwise, proceed as normally, and create >> refs/remotes/<nonmirrorremote>/HEAD instead. >> >> Reported-by: Christian Hesse <list@eworm.de> >> Signed-off-by: Bence Ferdinandy <bence@ferdinandy.com> > > Thanks, both of these patches look sensible to me.
Yeah, they read quite well. Thanks, all. Will queue.