Re: [PATCH] fetch set_head: fix non-mirror remotes in bare repositories

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jan 24, 2025, 10:30 UTC
Message-ID: <CAPig+cTE4ELybkuemQu_FT5BzqaKnVPYYA3dUOA64b7E_v=6PA@mail.gmail.com>
In-Reply-To: <Z5Mrk02wMdABtrVZ@pks.im>

On Fri, Jan 24, 2025 at 12:56 AM Patrick Steinhardt <ps@pks.im> wrote:

Show 9 quoted lines

> On Sun, Jan 12, 2025 at 05:51:22PM +0100, Bence Ferdinandy wrote:
> > +test_expect_success "fetch test remote HEAD in bare repository" '
> > +     cd "$D" &&
> > +     git init --bare barerepo &&
> > +     cd barerepo &&
>
> The `cd` needs to happen in a subshell. ALso, the same comment here
> regarding whether we want to have `test_when_finished` to clean up
> state.

By way of explanation regarding `cd` in a subshell, see [*].

[*]: https://lore.kernel.org/git/CAPig+cRsAPp1APNJ7W337UNtunETr+Lnn-RcGrAXEFUhN1APyA@mail.gmail.com/