Re: [PATCH v3 0/6] builtin/repo: include largest object information

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 2, 2026, 22:09 UTC
Message-ID: <xmqqqzq1yjcl.fsf@gitster.g>
In-Reply-To: <20260302214526.2034279-1-jltobler@gmail.com>

Justin Tobler <jltobler@gmail.com> writes:

Show 9 quoted lines

> Changes from V2:
> - When checking for largest objects, zero valued objects were not
>   recorded even if they were the "largest" object. In this version, if
>   an object ID has not been recorded yet, it is always added even if its
>   value is zero.
> - Added some helper functions for printing keyvalue info to cut down on
>   duplicate code and hopefully make it a bit easier on the eyes.
> - Moved the for-each loop that printed table OID annoations inside the
>   preceding if-block making it a bit easier to reason about.

The changes I see in the diff relative to the previous iteration all look sane to me. Will replace. Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.