Re: [PATCH v2 3/5] builtin/repo: add OID annotations to table output
On 26/02/26 11:56AM, Junio C Hamano wrote:
Show 17 quoted lines
> Justin Tobler <jltobler@gmail.com> writes:
>
> > + if (table->annotations.nr)
> > + printf("\n");
> > + for_each_string_list_item(item, &table->annotations)
> > + printf("%s\n", item->string);
> > +
>
> It is minor, but I suspect
>
> if (table->annotations.nr) {
> printf("\n");
> for_each_string_list_item(...)
> printf("%s\n", item->string);
> }
>
> would be easier to reason about.Makes sense, will update. Thanks.
-Justin