Re: [PATCH v3 0/6] builtin/repo: include largest object information
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 6, 2026, 22:36 UTC
- Message-ID
- <xmqq342cy49e.fsf@gitster.g>
- In-Reply-To
- <xmqqqzq1yjcl.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 14 quoted lines
> Justin Tobler <jltobler@gmail.com> writes: > >> Changes from V2: >> - When checking for largest objects, zero valued objects were not >> recorded even if they were the "largest" object. In this version, if >> an object ID has not been recorded yet, it is always added even if its >> value is zero. >> - Added some helper functions for printing keyvalue info to cut down on >> duplicate code and hopefully make it a bit easier on the eyes. >> - Moved the for-each loop that printed table OID annoations inside the >> preceding if-block making it a bit easier to reason about. > > The changes I see in the diff relative to the previous iteration all > look sane to me. Will replace. Thanks.
It seems that no further review comments are coming and new iterations are not happening on this topic, so shall we declare victory and mark the topic for 'next' now?
Thanks.