git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] SubmittingPatches: address design critiques

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 18, 2026, 15:40 UTC
Message-ID
<xmqqqzm3svq4.fsf@gitster.g>
In-Reply-To
<CAC2QwmJdF+YzAQE3WDEaUrurLVkYcAA0Cgs1YAqyxYcQ0jKfqA@mail.gmail.com>
Michael Montalbo <mmontalbo@gmail.com> writes:
Show 5 quoted lines
> Two small suggestions: open with a direct imperative and replace
> "effort in the implementation" with "effort on the implementation".
>
>     [B]e particularly mindful of...
>     ... too much effort [on] the implementation...

Yeah, I started from something like that then toned it down, but I agree that it is more appropriate to be more assertive here.

> Maybe it would help to spell out what the explanation/justification is
> for more explicitly (though it may be a bit redundant with the
> "meaningful message" blurb):

Yeah, and it depends on what kind of higher level issues the reviewer comment is about, so ...

Show 7 quoted lines
>     Make sure that any new version explains and justifies those
>     design decisions more clearly: why the change is worth making,
>     what alternatives were considered, and why the chosen approach
>     is correct.  Put that justification in the cover letter, your
>     responses, and the revised commit messages.  Aim to make the
>     reviewers say "it is now clear why we may want to do this with
>     the updated version".

... I find the beginning part of the above very much better than what I had in my version, but part of the first sentence after the colon is probably a bit too much.

I'll send out v3 sometime before the next week.
Thanks.
Previous: Kristoffer Haugsbakk
Message 4 of 4 in “Re: [PATCH] SubmittingPatches: address design critiques”
  1. Michael MontalboJun 18, 2026
  2. Michael MontalboJun 18, 2026
  3. Kristoffer HaugsbakkJun 18, 2026
  4. Junio C HamanoJun 18, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.