From: Junio C Hamano Date: Thu, 18 Jun 2026 15:40:19 GMT Subject: Re: [PATCH] SubmittingPatches: address design critiques Message-ID: In-Reply-To: Michael Montalbo writes: > Two small suggestions: open with a direct imperative and replace > "effort in the implementation" with "effort on the implementation". > > [B]e particularly mindful of... > ... too much effort [on] the implementation... Yeah, I started from something like that then toned it down, but I agree that it is more appropriate to be more assertive here. > Maybe it would help to spell out what the explanation/justification is > for more explicitly (though it may be a bit redundant with the > "meaningful message" blurb): Yeah, and it depends on what kind of higher level issues the reviewer comment is about, so ... > Make sure that any new version explains and justifies those > design decisions more clearly: why the change is worth making, > what alternatives were considered, and why the chosen approach > is correct. Put that justification in the cover letter, your > responses, and the revised commit messages. Aim to make the > reviewers say "it is now clear why we may want to do this with > the updated version". ... I find the beginning part of the above very much better than what I had in my version, but part of the first sentence after the colon is probably a bit too much. I'll send out v3 sometime before the next week. Thanks.