Re: [PATCH] SubmittingPatches: address design critiques
- From
Michael Montalbo <mmontalbo@gmail.com>
- Date
- Jun 18, 2026, 04:38 UTC
- Message-ID
- <CAC2QwmKXqaM5_AeEpNt04YRJa9K6G0vkFtfXvnq_QRShpmSoPQ@mail.gmail.com>
- In-Reply-To
- <CAC2QwmJdF+YzAQE3WDEaUrurLVkYcAA0Cgs1YAqyxYcQ0jKfqA@mail.gmail.com>
On Wed, Jun 17, 2026 at 8:53 PM Michael Montalbo <mmontalbo@gmail.com> wrote:
Show 14 quoted lines
> > Junio C Hamano wrote: > > +You would want to be particularly mindful of critiques regarding the > > +high-level design or viability of your proposal (e.g., questioning > > +whether the feature is worth implementing, or if the chosen approach > > +is appropriate). You want to defend your design decisions on the list > > +first, because you do not want to spend too much effort in the > > +implementation if the design is not yet solid. > > Two small suggestions: open with a direct imperative and replace > "effort in the implementation" with "effort on the implementation". > > [B]e particularly mindful of... > ... too much effort [on] the implementation...
Also, maybe we can even more directly say:
Do not spend too much effort on the implementation if the design is not yet solid. Be able to defend your design decisions on the list first.