git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: Fix the author initials in blame for non-ASCII names

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 30, 2013, 18:05 UTC
Message-ID
<xmqqppsvyrzj.fsf@gitster.dls.corp.google.com>
In-Reply-To
<1377851821-5412-1-git-send-email-avarab@gmail.com>
Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
Show 19 quoted lines
> Acked-by: Jakub Narębski <jnareb@gmail.com>
> Tested-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> Tested-by: Simon Ruderich <simon@ruderich.org>
> ---
>  gitweb/gitweb.perl | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index f429f75..ad48a5a 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -6631,6 +6631,7 @@ sub git_blame_common {
>  			$hash_base, '--', $file_name
>  			or die_error(500, "Open git-blame --porcelain failed");
>  	}
> +	binmode $fh, ':utf8';
>  
>  	# incremental blame data returns early
>  	if ($format eq 'data') {

[Fri Aug 30 17:48:17 2013] gitweb.perl: Global symbol "$fh" requires explicit package name at /home/gitster/w/buildfarm/next/t/../gitweb/gitweb.perl line 6634. [Fri Aug 30 17:48:17 2013] gitweb.perl: Execution of /home/gitster/w/buildfarm/next/t/../gitweb/gitweb.perl aborted due to compilation errors.

Previous: Ævar Arnfjörð BjarmasonNext: Jakub Narębski
Message 5 of 11 in “The gitweb author initials feature from a36817b doesn't work with i18n names”
  1. Ævar Arnfjörð BjarmasonAug 29, 2013
  2. Jakub NarębskiAug 29, 2013
  3. Simon RuderichAug 29, 2013
  4. gitweb: Fix the author initials in blame for non-ASCII namesÆvar Arnfjörð Bjarmason, Aug 30, 2013
  5. Junio C HamanoAug 30, 2013
  6. Jakub NarębskiAug 30, 2013
  7. Junio C HamanoAug 30, 2013
  8. Simon RuderichAug 30, 2013
  9. Kyle J. McKayAug 30, 2013
  10. Jakub NarębskiAug 31, 2013
  11. Ævar Arnfjörð BjarmasonAug 31, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.