Re: [PATCH] gitweb: Fix the author initials in blame for non-ASCII names

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Aug 31, 2013, 16:29 UTC
Message-ID: <CACBZZX4R2PRRRa=iqXQu_NhvFsTWM5+ktt-x4=sddvB_vptpqA@mail.gmail.com>
In-Reply-To: <xmqqhae7yrls.fsf@gitster.dls.corp.google.com>

I did. I just clumsily sent out the wrong patch. I.e. tested it manually on another system, and then fat-fingered $fh instead of $fd.

Should I send another patch or do you want to just fix this one up?

On Fri, Aug 30, 2013 at 8:13 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 20 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
>
>> Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
>>
>>> Acked-by: Jakub Narębski <jnareb@gmail.com>
>>> Tested-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
>>> Tested-by: Simon Ruderich <simon@ruderich.org>
>>> ---
>>> +++ b/gitweb/gitweb.perl
>>> @@ -6631,6 +6631,7 @@ sub git_blame_common {
>>> ...
>>> +    binmode $fh, ':utf8';
>
>>
>> [Fri Aug 30 17:48:17 2013] gitweb.perl: Global symbol "$fh" requires
>> explicit package name at /home/gitster/w/buildfarm/next/t/../gitweb/gitweb.perl line 6634.
>> [Fri Aug 30 17:48:17 2013] gitweb.perl: Execution of /home/gitster/w/buildfarm/next/t/../gitweb/gitweb.perl aborted due to compilation errors.
>
> I think in this function the filehandle is called $fd, not $fh.  Has
> any of you really tested this???