Re: [PATCH] gitweb: Fix the author initials in blame for non-ASCII names

From: Jakub Narębski <jnareb@gmail.com>
Date: Aug 30, 2013, 18:08 UTC
Message-ID: <CANQwDwcyTWgk0jhhGUgP-UZDLQ5EGhh5oueitGD5fpgS5bLtzw@mail.gmail.com>
In-Reply-To: <xmqqppsvyrzj.fsf@gitster.dls.corp.google.com>

On Fri, Aug 30, 2013 at 8:05 PM, Junio C Hamano <gitster@pobox.com> wrote:

> Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

Show 16 quoted lines

>> Acked-by: Jakub Narębski <jnareb@gmail.com>
>> Tested-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
>> Tested-by: Simon Ruderich <simon@ruderich.org>
>> ---
>>  gitweb/gitweb.perl | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
>> index f429f75..ad48a5a 100755
>> --- a/gitweb/gitweb.perl
>> +++ b/gitweb/gitweb.perl
>> @@ -6631,6 +6631,7 @@ sub git_blame_common {
>>                       $hash_base, '--', $file_name
>>                       or die_error(500, "Open git-blame --porcelain failed");
>>       }
>> +     binmode $fh, ':utf8';

Should be $fd, not $fh.

> [Fri Aug 30 17:48:17 2013] gitweb.perl: Global symbol "$fh" requires
> explicit package name at /home/gitster/w/buildfarm/next/t/../gitweb/gitweb.perl line 6634.
> [Fri Aug 30 17:48:17 2013] gitweb.perl: Execution of /home/gitster/w/buildfarm/next/t/../gitweb/gitweb.perl aborted due to compilation errors.

I wonder how it passed Ævar and Simon tests. Perhaps proposal had $fd?

-- 
Jakub Narebski