git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/7] l10n: unpack-trees: mark strings for translation

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 8, 2016, 20:23 UTC
Message-ID
<xmqqpotzvoia.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<1460145765-7454-2-git-send-email-vascomalmeida@sapo.pt>
Vasco Almeida <vascomalmeida@sapo.pt> writes:
Show 6 quoted lines
> Mark strings seen by the user inside setup_unpack_trees_porcelain() and
> display_error_msgs() functions for translation.
>
> One case Git outputs the named strings is when the user does some editing to
> a file on some branch and then checks out other branch, but that file
> changes by the checkout. This is the case of the first string marked.

The second paragraph puzzling. Other strings are not shown at all? Or is it just you didn't bother explaining the others cases?

Either case, it is not immediately clear why you felt that one string among others deserve more attention. Care to elaborate?

In the patch itself I did not find anything questionable, though.
Thanks.
Show 67 quoted lines
>
> Signed-off-by: Vasco Almeida <vascomalmeida@sapo.pt>
> ---
>  unpack-trees.c | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/unpack-trees.c b/unpack-trees.c
> index 9f55cc2..4bc6b4f 100644
> --- a/unpack-trees.c
> +++ b/unpack-trees.c
> @@ -61,21 +61,21 @@ void setup_unpack_trees_porcelain(struct unpack_trees_options *opts,
>  	const char *cmd2 = strcmp(cmd, "checkout") ? cmd : "switch branches";
>  
>  	if (advice_commit_before_merge)
> -		msg = "Your local changes to the following files would be overwritten by %s:\n%%s"
> -			"Please, commit your changes or stash them before you can %s.";
> +		msg = _("Your local changes to the following files would be overwritten by %s:\n%%s"
> +			"Please, commit your changes or stash them before you can %s.");
>  	else
> -		msg = "Your local changes to the following files would be overwritten by %s:\n%%s";
> +		msg = _("Your local changes to the following files would be overwritten by %s:\n%%s");
>  	msgs[ERROR_WOULD_OVERWRITE] = msgs[ERROR_NOT_UPTODATE_FILE] =
>  		xstrfmt(msg, cmd, cmd2);
>  
>  	msgs[ERROR_NOT_UPTODATE_DIR] =
> -		"Updating the following directories would lose untracked files in it:\n%s";
> +		_("Updating the following directories would lose untracked files in it:\n%s");
>  
>  	if (advice_commit_before_merge)
> -		msg = "The following untracked working tree files would be %s by %s:\n%%s"
> -			"Please move or remove them before you can %s.";
> +		msg = _("The following untracked working tree files would be %s by %s:\n%%s"
> +			"Please move or remove them before you can %s.");
>  	else
> -		msg = "The following untracked working tree files would be %s by %s:\n%%s";
> +		msg = _("The following untracked working tree files would be %s by %s:\n%%s");
>  
>  	msgs[ERROR_WOULD_LOSE_UNTRACKED_REMOVED] = xstrfmt(msg, "removed", cmd, cmd2);
>  	msgs[ERROR_WOULD_LOSE_UNTRACKED_OVERWRITTEN] = xstrfmt(msg, "overwritten", cmd, cmd2);
> @@ -84,14 +84,14 @@ void setup_unpack_trees_porcelain(struct unpack_trees_options *opts,
>  	 * Special case: ERROR_BIND_OVERLAP refers to a pair of paths, we
>  	 * cannot easily display it as a list.
>  	 */
> -	msgs[ERROR_BIND_OVERLAP] = "Entry '%s' overlaps with '%s'.  Cannot bind.";
> +	msgs[ERROR_BIND_OVERLAP] = _("Entry '%s' overlaps with '%s'.  Cannot bind.");
>  
>  	msgs[ERROR_SPARSE_NOT_UPTODATE_FILE] =
> -		"Cannot update sparse checkout: the following entries are not up-to-date:\n%s";
> +		_("Cannot update sparse checkout: the following entries are not up-to-date:\n%s");
>  	msgs[ERROR_WOULD_LOSE_ORPHANED_OVERWRITTEN] =
> -		"The following Working tree files would be overwritten by sparse checkout update:\n%s";
> +		_("The following Working tree files would be overwritten by sparse checkout update:\n%s");
>  	msgs[ERROR_WOULD_LOSE_ORPHANED_REMOVED] =
> -		"The following Working tree files would be removed by sparse checkout update:\n%s";
> +		_("The following Working tree files would be removed by sparse checkout update:\n%s");
>  
>  	opts->show_all_errors = 1;
>  	/* rejected paths may not have a static buffer */
> @@ -168,7 +168,7 @@ static void display_error_msgs(struct unpack_trees_options *o)
>  		string_list_clear(rejects, 0);
>  	}
>  	if (something_displayed)
> -		fprintf(stderr, "Aborting\n");
> +		fprintf(stderr, _("Aborting\n"));
>  }
>  
>  /*
Previous: Vasco AlmeidaNext: Vasco Almeida
Message 3 of 14 in “l10n: index-pack: use plural string instead of normal one”
  1. 1/7 l10n: index-pack: use plural string instead of normal oneVasco Almeida, Apr 8, 2016
  2. 2/7 l10n: unpack-trees: mark strings for translationVasco Almeida, Apr 8, 2016
  3. Junio C HamanoApr 8, 2016
  4. Vasco AlmeidaApr 9, 2016
  5. 3/7 l10n: git-parse-remote.sh: mark strings for translationVasco Almeida, Apr 8, 2016
  6. Junio C HamanoApr 8, 2016
  7. 4/7 l10n: builtin/pull.c: mark strings for translationVasco Almeida, Apr 8, 2016
  8. Junio C HamanoApr 8, 2016
  9. Vasco AlmeidaApr 9, 2016
  10. 5/7 l10n: builtin/pull.c: split strings marked for translationVasco Almeida, Apr 8, 2016
  11. 6/7 l10n: mv.c: add a comma ',' to stringVasco Almeida, Apr 8, 2016
  12. Junio C HamanoApr 8, 2016
  13. 7/7 l10n: builtin/branch.c: mark option for translationVasco Almeida, Apr 8, 2016
  14. Junio C HamanoApr 8, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.