Re: [PATCH 4/7] l10n: builtin/pull.c: mark strings for translation

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 8, 2016, 20:33 UTC
Message-ID: <xmqqd1pzvo0p.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1460145765-7454-4-git-send-email-vascomalmeida@sapo.pt>

Vasco Almeida <vascomalmeida@sapo.pt> writes:

Show 6 quoted lines

> Some translations might also translate "<remote>" and "<branch>".
> ...
>  		fprintf_ln(stderr, _("See git-pull(1) for details."));
>  		fprintf(stderr, "\n");
> -		fprintf_ln(stderr, "    git pull <remote> <branch>");
> +		fprintf_ln(stderr, _("    git pull <remote> <branch>"));

But "git pull" itself must never be translated, and there is no hint given to those who are working on *.po files to prevent it.

Wouldn't it make more sense to do it like this?

	fprintf_ln(stderr, "    git pull <%s> <%s>", _("remote"), _("branch"));