Re: [PATCH 6/7] l10n: mv.c: add a comma ',' to string

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 8, 2016, 20:35 UTC
Message-ID: <xmqq8u0nvnxq.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1460145765-7454-6-git-send-email-vascomalmeida@sapo.pt>

Vasco Almeida <vascomalmeida@sapo.pt> writes:

> Add a comma to string marked for translation. Make the string match the
> one in rm.c. Now translators have do handle this string only once.

I suspect these "comma after Please" is a French invention.

Aiming to reduce these minor variants is a good goal, but wouldn't we want to go in the opposite direction?

Show 19 quoted lines

>
> Signed-off-by: Vasco Almeida <vascomalmeida@sapo.pt>
> ---
>  builtin/mv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/mv.c b/builtin/mv.c
> index aeae855..1bf8df1 100644
> --- a/builtin/mv.c
> +++ b/builtin/mv.c
> @@ -69,7 +69,7 @@ static void prepare_move_submodule(const char *src, int first,
>  	if (!S_ISGITLINK(active_cache[first]->ce_mode))
>  		die(_("Directory %s is in index and no submodule?"), src);
>  	if (!is_staging_gitmodules_ok())
> -		die(_("Please stage your changes to .gitmodules or stash them to proceed"));
> +		die(_("Please, stage your changes to .gitmodules or stash them to proceed"));
>  	strbuf_addf(&submodule_dotgit, "%s/.git", src);
>  	*submodule_gitfile = read_gitfile(submodule_dotgit.buf);
>  	if (*submodule_gitfile)