Re: [PATCH v2 14/22] i18n: rebase-interactive: mark strings for translation

From: Junio C Hamano <gitster@pobox.com>
Date: May 26, 2016, 22:36 UTC
Message-ID: <xmqqpos8tpjo.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1464031661-18988-15-git-send-email-vascomalmeida@sapo.pt>

Vasco Almeida <vascomalmeida@sapo.pt> writes:

Show 14 quoted lines

> @@ -222,9 +223,10 @@ has_action () {
>  }
>  
>  is_empty_commit() {
> -	tree=$(git rev-parse -q --verify "$1"^{tree} 2>/dev/null ||
> -		die "$1: not a commit that can be picked")
> -	ptree=$(git rev-parse -q --verify "$1"^^{tree} 2>/dev/null ||
> +	sha1=$1
> +	tree=$(git rev-parse -q --verify "$sha1"^{tree} 2>/dev/null ||
> +		die "$(eval_gettext "\$sha1: not a commit that can be picked")")
> +	ptree=$(git rev-parse -q --verify "$sha1"^^{tree} 2>/dev/null ||
>  		ptree=4b825dc642cb6eb9a060e54bf8d69288fbee4904)
>  	test "$tree" = "$ptree"
>  }

Both of the two callsites of this function use the variable $sha1, and at least one of them uses that variable after this function returns, but they pass it as the first parameter to this function, so the assignment added by this patch does not break them, which is good.