Re: [PATCH v2 18/22] tests: use test_i18n* functions to suppress false positives

From: Junio C Hamano <gitster@pobox.com>
Date: May 27, 2016, 17:08 UTC
Message-ID: <xmqqd1o7sa30.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1464031661-18988-19-git-send-email-vascomalmeida@sapo.pt>

Vasco Almeida <vascomalmeida@sapo.pt> writes:

Show 11 quoted lines

> diff --git a/t/t1307-config-blob.sh b/t/t1307-config-blob.sh
> index 3c6791e..4079fef 100755
> --- a/t/t1307-config-blob.sh
> +++ b/t/t1307-config-blob.sh
> @@ -64,7 +64,7 @@ test_expect_success 'parse errors in blobs are properly attributed' '
>  
>  	# just grep for our token as the exact error message is likely to
>  	# change or be internationalized
> -	grep "HEAD:config" err
> +	test_i18ngrep "HEAD:config" err
>  '

It is unfortunate that the gettext-poison mechanism is too dumb to notice that it is clobbering a format string with placeholders and leave them intact, which is what the comment above this change is wishing for. I do not think we will be granting that wish any time soon, so perhaps remove the two lines while we are at it?