Re: [PATCH v2 2/3] serialize collection of refs that contain submodule changes
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 10, 2016, 22:48 UTC
- Message-ID
- <xmqqpon7bz26.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <81bdbf6a1295c17c1b9233c91da6e5eb4583785e.1475851621.git.hvoigt@hvoigt.net>
Heiko Voigt <hvoigt@hvoigt.net> writes:
Show 6 quoted lines
> +static int append_hash_to_argv(const unsigned char sha1[20], void *data)
> +{
> + struct argv_array *argv = (struct argv_array *) data;
> + argv_array_push(argv, sha1_to_hex(sha1));
> + return 0;
> +}Do we have struct object_id readily available in the caller?
... goes and looks ...
No, this is part of sha1_array API, so this callback is perfectly fine.