Re: [PATCH v2 1/3] serialize collection of changed submodules

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 12, 2016, 17:18 UTC
Message-ID: <xmqq1szl5vvf.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20161012130034.GA84247@book.hvoigt.net>

Heiko Voigt <hvoigt@hvoigt.net> writes:

Show 5 quoted lines

> Which seems quite extensively long for a static function so how about
> we shorten it a bit and add a comment:
>
> 	/* lookup or create commit object list for submodule */
> 	get_commit_objects_for_submodule_path(...

Or you can even lose "get_" and "path", I guess. You are not even "getting" commits but the array that holds them, so the caller can use it to "get" one of them or it can even use it to "put" a new one, no? "get-commit-objects" is a misnomer in that sense. Either one of

    get_submodule_commits_array()
    submodule_commits()

perhaps?  I dunno.