Re: [RFC] Indicate that Git waits for user input via editor
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 16, 2017, 00:33 UTC
- Message-ID
- <xmqqpo8jxdto.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <CAGZ79kZbm8SGY4rXKZHV82E-HX9qbQ4iyCbMgJEBFQf4fj3u=Q@mail.gmail.com>
Stefan Beller <sbeller@google.com> writes:
Show 20 quoted lines
>> I wonder if we can do something like
>>
>> git_spawn_editor()
>> {
>> const char *EL = "\033[K"; /* Erase in Line */
>>
>> /* notice the lack of terminating LF */
>> fprintf(stderr, "Launching your editor...");
>
> "It takes quite some time to launch this special Git Editor"
>
> As Lars pointed out, the editor may be launched in the background,
> that the user would not know, but they might expect a thing to
> pop up as a modal dialog as is always with UIs.
>
> So despite it being technically wrong at this point in time,
> I would phrase it in past tense or in a way that indicates that the
> user needs to take action already.
>
> The "Launching..." sounds as if I need to wait for an event to occur.Heh, I wasn't expecting phrasing nitpicks when I was trying to help the thread by trying to come up with a way to avoid vertical space wastage.