git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] launch_editor(): indicate that Git waits for user input

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 17, 2017, 01:09 UTC
Message-ID
<xmqq8tf5vhh4.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<DAA0F91D-5180-4C3B-B0E8-7C917915AC6F@gmail.com>
Lars Schneider <larsxschneider@gmail.com> writes:
Show 14 quoted lines
>> On 16 Nov 2017, at 15:58, Junio C Hamano <gitster@pobox.com> wrote:
>> 
>> Lars Schneider <larsxschneider@gmail.com> writes:
>> 
>>>> On 16 Nov 2017, at 07:04, Junio C Hamano <gitster@pobox.com> wrote:
>>> 
>>> Wow. Thanks for the quick patch :-)
>> 
>> Heh, this is not exactly my itch, so if you are inclined to, can you
>> take it over from here on?
>
> Absolutely! What is the proper way to proceed here? Should I send a v2
> with the changes I suggested? How do I attribute you correctly? I
> assume I need to remove your 'Signed-off-by:'?

If you are making major changes over the original patch, you'd probably want to take the authorship and mention me on Helped-by: and/or add "This is based on a previous work by...", if you want to credit me.

If you are not taking the authorship over, then doing something like
    https://public-inbox.org/git/xmqqshdex0ff.fsf@gitster.mtv.corp.google.com/
would be sufficient, I would think.
Thanks.
Previous: Lars SchneiderNext: Kaartic Sivaraam
Message 14 of 16 in “[RFC] Indicate that Git waits for user input via editor”
  1. Lars SchneiderNov 15, 2017
  2. Stefan BellerNov 15, 2017
  3. Lars SchneiderNov 15, 2017
  4. Stefan BellerNov 15, 2017
  5. Junio C HamanoNov 15, 2017
  6. Stefan BellerNov 16, 2017
  7. Junio C HamanoNov 16, 2017
  8. Stefan BellerNov 16, 2017
  9. Junio C HamanoNov 16, 2017
  10. launch_editor(): indicate that Git waits for user inputJunio C Hamano, Nov 16, 2017
  11. Lars SchneiderNov 16, 2017
  12. Junio C HamanoNov 16, 2017
  13. Lars SchneiderNov 16, 2017
  14. Junio C HamanoNov 17, 2017
  15. Kaartic SivaraamNov 18, 2017
  16. Junio C HamanoNov 19, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.