Re: [PATCH] launch_editor(): indicate that Git waits for user input
- From
Lars Schneider <larsxschneider@gmail.com>
- Date
- Nov 16, 2017, 15:24 UTC
- Message-ID
- <DAA0F91D-5180-4C3B-B0E8-7C917915AC6F@gmail.com>
- In-Reply-To
- <xmqqh8tuuv6l.fsf@gitster.mtv.corp.google.com>
Show 10 quoted lines
> On 16 Nov 2017, at 15:58, Junio C Hamano <gitster@pobox.com> wrote: > > Lars Schneider <larsxschneider@gmail.com> writes: > >>> On 16 Nov 2017, at 07:04, Junio C Hamano <gitster@pobox.com> wrote: >> >> Wow. Thanks for the quick patch :-) > > Heh, this is not exactly my itch, so if you are inclined to, can you > take it over from here on?
Absolutely! What is the proper way to proceed here? Should I send a v2 with the changes I suggested? How do I attribute you correctly? I assume I need to remove your 'Signed-off-by:'?
Thanks, Lars