Re: [PATCH 2/2] trace: improve performance while category is disabled

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 27, 2017, 01:21 UTC
Message-ID: <xmqqpo84fre1.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20171126201119.24313-2-gennady.kupava@gmail.com>

gennady.kupava@gmail.com writes:

Show 6 quoted lines

> From: Gennady Kupava <gkupava@bloomberg.net>
>
> - Do the check if the trace key is enabled sooner in call chain.
> - Move just enough code from trace.c into trace.h header so all code
>   necessary to determine that trace is disabled could be inlined to
>   calling functions.

Makes sense.  Will queue.

Thanks.

> +inline int trace_pass_fl(struct trace_key *key) {
> +	return key->fd || !key->initialized;
> +}

;-)