From: Junio C Hamano Date: Mon, 27 Nov 2017 01:21:26 GMT Subject: Re: [PATCH 2/2] trace: improve performance while category is disabled Message-ID: In-Reply-To: <20171126201119.24313-2-gennady.kupava@gmail.com> gennady.kupava@gmail.com writes: > From: Gennady Kupava > > - Do the check if the trace key is enabled sooner in call chain. > - Move just enough code from trace.c into trace.h header so all code > necessary to determine that trace is disabled could be inlined to > calling functions. Makes sense. Will queue. Thanks. > +inline int trace_pass_fl(struct trace_key *key) { > + return key->fd || !key->initialized; > +} ;-)