Re: [PATCH 2/2] trace: improve performance while category is disabled

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 27, 2017, 03:25 UTC
Message-ID: <xmqq8tesflne.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqqlgisfquy.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 9 quoted lines

> Just in case others notice style and whitespace issues, I've applied
> the following to fix them, so there is no need to reroll only to fix
> these.
> ...
> -inline int trace_pass_fl(struct trace_key *key) {
> +inline int trace_pass_fl(struct trace_key *key)
> +{
>  	return key->fd || !key->initialized;
>  }

Spotted yet another. This function in a header file, that is included by many source files, must be made "static inline" (which I already did as without the fix I couldn't get 'pu' to compile).