Re: [PATCH v7 4/7] checkout: describe_detached_head: remove ellipsis after committish
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 6, 2017, 16:47 UTC
- Message-ID
- <xmqqpo7rhkg7.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20171206002042.18863-1-bedhanger@gmx.de>
Ann T Ropea <bedhanger@gmx.de> writes:
> v7: fix style issues (redirection, here-dox, long lines, setting/exporting/unsetting of env var): cf. <xmqq8tehjh6f.fsf@gitster.mtv.corp.google.com>
Thanks. I'd say this is polished enough already. Let's stop rerolling, wait for a few days for others to give final comments and merge it to 'next'.
I've however queued the following on top of the entire series. I do not mind squashing it into this step, though.
-- >8 -- Subject: [PATCH] t2020: test variations that matter
Because our test suite is not about validating the working of the shell, it is pointless to test variations of how a literal string 'yes' is quoted when assigned to an environment variable.
Instead, test various ways to spell 'yes' (we use strcasecmp() so uppercased and capitalized variant should work just like 'yes' spelled in all lowercase) and make sure we take them as 'yes'. That is more relevant in testing Git.
Signed-off-by: Junio C Hamano <gitster@pobox.com> --- t/t2020-checkout-detach.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/t/t2020-checkout-detach.sh b/t/t2020-checkout-detach.sh index 9464069d15..bb4f2e0c63 100755 --- a/t/t2020-checkout-detach.sh +++ b/t/t2020-checkout-detach.sh @@ -294,15 +294,15 @@ test_expect_success 'describe_detached_head does print SHA-1 ellipsis when asked # Various ways of asking for ellipses... # The user can just use any kind of quoting (including none). - GIT_PRINT_SHA1_ELLIPSIS="yes" git -c 'core.abbrev=12' checkout HEAD^ >actual 2>&1 && + GIT_PRINT_SHA1_ELLIPSIS=yes git -c 'core.abbrev=12' checkout HEAD^ >actual 2>&1 && check_detached && test_i18ncmp 1st_detach actual && - GIT_PRINT_SHA1_ELLIPSIS='yes' git -c 'core.abbrev=12' checkout HEAD^ >actual 2>&1 && + GIT_PRINT_SHA1_ELLIPSIS=Yes git -c 'core.abbrev=12' checkout HEAD^ >actual 2>&1 && check_detached && test_i18ncmp 2nd_detach actual && - GIT_PRINT_SHA1_ELLIPSIS=yes git -c 'core.abbrev=12' checkout HEAD^ >actual 2>&1 && + GIT_PRINT_SHA1_ELLIPSIS=YES git -c 'core.abbrev=12' checkout HEAD^ >actual 2>&1 && check_detached && test_i18ncmp 3rd_detach actual &&
-- 2.15.1-465-g070199a3f5